London | 26-ITP-Jan | Adnaan Abo | Sprint 2 | Form Control#1072
Open
AdnaanA wants to merge 2 commits intoCodeYourFuture:mainfrom
Open
London | 26-ITP-Jan | Adnaan Abo | Sprint 2 | Form Control#1072AdnaanA wants to merge 2 commits intoCodeYourFuture:mainfrom
AdnaanA wants to merge 2 commits intoCodeYourFuture:mainfrom
Conversation
form created with specific fields
improved accessibility score.
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
AdnaanA
added
the
Needs Review
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
github-actions
bot
removed
the
Needs Review
AdnaanA
added
📅 Sprint 1
This comment has been minimized.
This comment has been minimized.
2 similar comments
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
github-actions
bot
removed
the
Needs Review
This comment has been minimized.
This comment has been minimized.
2 similar comments
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
AdnaanA
added
the
Needs Review
This comment has been minimized.
This comment has been minimized.
github-actions
bot
removed
the
Needs Review
AdnaanA
changed the title
AdnaanA
added
Needs Review
cjyuan
reviewed
Feb 5, 2026
Contributor
cjyuan
left a comment
cjyuan
left a comment
There was a problem hiding this comment.
In the PR description, the "Changelist" section only contains a header. Can you include a brief description of what you have changed?
| <legend>Customer Information</legend> | ||
|
|
||
| <label for="first_name">First Name:</label><br /> | ||
| <input type="text" id="first_name" name="first_name" required minlength="2" /><br /><br /> |
Contributor
There was a problem hiding this comment.
Currently a user can enter a name consisting of only space characters (e.g., " "). Can you enforce a stricter validation rule using the pattern attribute to disallow any name that contains only space characters?
Comment on lines
+39
to
+51
| <label> | ||
| <input type="radio" name="color" value="red" required /> | ||
| Red | ||
| </label> | ||
| <label> | ||
| <input type="radio" name="color" value="blue" required /> | ||
| Blue | ||
| </label> | ||
| <label> | ||
| <input type="radio" name="color" value="green" required /> | ||
| Green | ||
| </label><br /><br /> | ||
| </div> |
Contributor
There was a problem hiding this comment.
Since these three radio buttons belong to the same button group (share the same name value), we don't need required in all input elements; one is enough.
cjyuan
added
Reviewed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Self checklist
Changelist